Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better CE error reporting when using use! with and! #17671

Merged
merged 13 commits into from
Sep 10, 2024
Merged

Better CE error reporting when using use! with and! #17671

merged 13 commits into from
Sep 10, 2024

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Sep 8, 2024 •
edited
Loading

Description

  • Improves the error range for use! may not be combined with and!
  • Updates SynExprAndBangTrivia to include also AndBangKeyword range
  • Uses only the and! range since it's what adds the error in the first place.

Before

Screenshot 2024-09-08 at 16 32 46

After

let run r2 r3 =
    result {
        use! b = r2
        and! c = r3
        ^^^^
        return b - c
    }

Checklist

  • Test cases added
  • Release notes entry updated

@edgarfgp edgarfgp requested a review from a team as a code owner September 8, 2024 15:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@auduchinok
Copy link
Member

@edgarfgp Could it be better to highlight the and! part, since it's what adds the error? Could it also highlight the keyword only?

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Sep 8, 2024 •
edited
Loading

Could it be better to highlight the and! part, since it's what adds the error? Could it also highlight the keyword only?

Yeah I think that makes more sense. Thanks for the review.

Update: Unfortunately there is not a dedicated range for only the and keyword. So the best we can do for now if the expression range. See fantomas

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Sep 8, 2024

@auduchinok I played around with your suggestion and I was able to update SynExprAndBangTrivia to also include and! range.

@edgarfgp edgarfgp closed this Sep 8, 2024
@edgarfgp edgarfgp reopened this Sep 8, 2024
psfinaki
psfinaki approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, I like this approach with adding trivia. Thanks for making diags better every week :)

@edgarfgp
Copy link
Contributor Author

@psfinaki I have more planned for CE in the upcoming weeks

@psfinaki psfinaki merged commit 92754eb into dotnet:main Sep 10, 2024
30 checks passed
@dotnet-bot dotnet-bot mentioned this pull request Sep 17, 2024
Closed
@edgarfgp edgarfgp mentioned this pull request Sep 20, 2024
Merged
2 tasks
@dotnet-bot dotnet-bot mentioned this pull request Sep 21, 2024
Closed
@edgarfgp edgarfgp mentioned this pull request Sep 23, 2024
Merged
2 tasks
@dotnet-bot dotnet-bot mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel left review comments

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edgarfgp @auduchinok @baronfel @vzarytovskii @psfinaki